-
Notifications
You must be signed in to change notification settings - Fork 73
copilot-bluespec: Disable test suite via newly added manual cabal flag. Refs #673.
#702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copilot-bluespec: Disable test suite via newly added manual cabal flag. Refs #673.
#702
Conversation
copilot-bluespec: Update copilot-bluespec.cabal to only run tests when passed "test-bluespec" flag. Refs #673.
|
Change Manager: @chathhorn-galois Can you please make the following changes to keep some entries and messages a bit shorter?
In the commit message for the first commit, can you please modify the summary line to read similarly? Please make these changes modifying your existing commits (without adding any more commits on top), and push force to your branch so that the PR is updated automatically. Thanks! |
…g. Refs Copilot-Language#673. The copilot-bluespec package requires bsc (the Bluespec compiler) to be installed in order to run its test suite, but the builders that Hackage uses to run uploaded packages' test suites do not have bsc installed, causing Hackage to spuriously claim that copilot-bluespec's tests are failing. This commit adds a cabal flag `test-bluespec` intended to enable tests that require the Bluespec compiler (`bsc`) to run. The default behavior of `cabal test` (with no flags) is now to not build the testsuite, preventing spurious test failures from appearing in Hackage reports. To enable building the testsuite, use: `cabal test -f test-bluespec`.
f72d605 to
03fc7d4
Compare
|
Implementor: Fix implemented, review requested. |
copilot-bluespec: Update copilot-bluespec.cabal to only run tests when passed "test-bluespec" flag. Refs #673.copilot-bluespec: Disable test suite via newly added manual cabal flag. Refs #673.
|
Change Manager: Verified that:
|
The copilot-bluespec package requires bsc (the Bluespec compiler) to be installed in order to run its test suite, but the builders that Hackage uses to run uploaded packages' test suites do not have bsc installed, causing Hackage to spuriously claim that copilot-bluespec's tests are failing.
This PR adds a cabal flag
test-bluespecintended to enable tests that require the Bluespec compiler (bsc) to run. The default behavior ofcabal test(with no flags) is now to not build the testsuite, preventing spurious test failures from appearing in Hackage reports. To enable building the testsuite, use:cabal test -f test-bluespec.Fixes #673.